search

linuxdeploy / linuxdeploy-plugin-gstreamer

Bundles GStreamer plugins into AppDirs. Experimental code, please expect issues! Help welcome!
3 stars 11 forks source link

error "command not found" due to return code in double quotes #11

Closed zerobikappa closed 2 years ago

zerobikappa commented 2 years ago

error due to place the return code in double quotes

https://github.com/linuxdeploy/linuxdeploy-plugin-gstreamer/blob/f7881a481616bb6f0c648a946747fda9de0f5275/linuxdeploy-plugin-gstreamer.sh#L110

https://github.com/linuxdeploy/linuxdeploy-plugin-gstreamer/blob/f7881a481616bb6f0c648a946747fda9de0f5275/linuxdeploy-plugin-gstreamer.sh#L130

should be

$(file "$i" | grep -v ELF --silent) && echo "Ignoring non ELF file: $i" && continue
TheAssassin commented 2 years ago

Actually, it should be (file "$i" | grep -v ELF --silent) && echo "Ignoring non ELF file: $i" && continue. The leading $ will capture the subshell's output into a string, that's why it doesn't work.

Please send a PR.

zerobikappa commented 2 years ago

after I submitted PR, I found someone already did the same thing(https://github.com/linuxdeploy/linuxdeploy-plugin-gstreamer/pull/6) 1 year ago. but the PR was still pending in queue till now...

zerobikappa commented 2 years ago

13