search

linuxdeploy / linuxdeploy-plugin-gstreamer

Bundles GStreamer plugins into AppDirs. Experimental code, please expect issues! Help welcome!
3 stars 11 forks source link

add support for 32&64 bit gstreamer and different linux distribution #14

Closed zerobikappa closed 1 year ago

zerobikappa commented 2 years ago

Add support for 32&64 bit gstreamer due to the current version only copy 32-bit and 64-bit plugins in the same place. Add support for different linux distribution due to different library path in different distribution. I did not add option to specify the $plugins_target_dir, only keep the same structure between / and $APPDIR. If necessary to add option to specify the $plugins_target_dir, please tell me, thanks.

TheAssassin commented 2 years ago

Please run shellcheck on the script and fix the escaping issues.

zerobikappa commented 2 years ago

I'm a new beginner of git. if I did something wrong, I will apologize -- should I leave a comment here so that github will tell you I submitted the changes? or I can just push my changes to my fork then wait for your comment, without leaving a comment here?

TheAssassin commented 2 years ago

Just pushing is enough to trigger a notification. You need to wait for people to have time, though.

zerobikappa commented 2 years ago

OK, thank you. I just find out some error in my script, I will fix it later. no need to review this PR immediately at this moment.

zerobikappa commented 2 years ago

well, at last I completed my fork. however, finally I got some doubt whether it is really necessary to add support for other distro. because it seems to be more recommended to package appimage in the oldest still-support ubuntu system. please let me know you comment.

TheAssassin commented 2 years ago

We're making progress here. I've left a few comments.

TheAssassin commented 2 years ago

I got some doubt whether it is really necessary to add support for other distro. because it seems to be more recommended to package appimage in the oldest still-support ubuntu system.

Even if it is just a recommendation (I think it is, some people may be more restrictive), old systems must still be supported to allow people to follow this recommendation. If a script just doesn't work on older distros any more, you would force people to use more recent base systems. That does not make sense.