search

linuxerwang / rkflashkit

rkflashkit is an open source toolkit for flashing Linux kernel images to rockchip rk3066/rk3188/rk3288 etc. based devices. It's programmed with python and gtk2.
214 stars 74 forks source link

Support RK3399? #10

Closed BiatuAutMiahn closed 7 years ago

BiatuAutMiahn commented 7 years ago

Can you add support for the Firefly-RK3399?

linuxerwang commented 7 years ago

What's its product ID?

BiatuAutMiahn commented 7 years ago

Where can I find that?

This is the product: http://en.t-firefly.com/en/firenow/Firefly_RK3399/

cdslashetc commented 7 years ago

The Firefly team already made a fork with RK3399 support https://github.com/T-Firefly/rkflashkit you can find more information in the Flash Image section of the wiki http://wiki.t-firefly.com/index.php/Firefly-RK3399/en

A good tip for Github in general is I find it's useful to click on the number to the right of Fork at the top of the page sometimes someone already made a fork with the features that you need or projects are abandoned but forked and continued by somebody else.

linuxerwang commented 7 years ago

They can create a pull request and I'll be happy to merge it.

On Sun, Apr 2, 2017 at 7:34 AM Jonathan Dill notifications@github.com wrote:

The Firefly team already made a fork with RK3399 support https://github.com/T-Firefly/rkflashkit you can find more information in the Flash Image section of the wiki http://wiki.t-firefly.com/index.php/Firefly-RK3399/en

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/linuxerwang/rkflashkit/issues/10#issuecomment-290990153, or mute the thread https://github.com/notifications/unsubscribe-auth/ADJsHrYZiq-NtqhmhqxcVbs-zOJhUnHCks5rr7HpgaJpZM4Mwth1 .

cdslashetc commented 7 years ago

Cool! I'll let them know.

They have Issues disabled on their repo, so I posted a message in the discussion forum, hopefully somebody will read it, would probably be more effective on the Chinese language forums which are more active, but I don't know Chinese yet.

BiatuAutMiahn commented 7 years ago

ya, that's why I made this issue. and I used they're fork, but unfortunately it does not work. it does not detect the RK3399, but the Linux Firmware Tool does just fine

linuxerwang commented 7 years ago

The key is this line: https://github.com/linuxerwang/rkflashkit/blob/master/src/rkflashkit/rktalk.py#L28

Someone has to tell me the product ID for RK3399, since I don't have any such devices.

BiatuAutMiahn commented 7 years ago

well, as a LOADER device it is 0x330C (for the PID). Sorry didn't know if u were talking about the VID/PID until i seen the source

linuxerwang commented 7 years ago

Added with commit dd6829702abd2d195d9fe41648b08dcba683ba87.