linuxerwang / rkflashkit

rkflashkit is an open source toolkit for flashing Linux kernel images to rockchip rk3066/rk3188/rk3288 etc. based devices. It's programmed with python and gtk2.
214 stars 74 forks source link

Does not find partition with unspecified size #3

Open dalanbrown opened 9 years ago

dalanbrown commented 9 years ago

My command like looks like this: CMDLINE: initrd=0x62000000,0x00800000 init=/sbin/init root=/dev/mtdblock2 mtdparts=rk29xxnand:0x00008000@0x00002000(boot),0x00008000@0x0000A000(kernel),-@0x00012000(system)

rkflashkit correctly finds boot and kernel partitions but does not see the system partition because the size is unspecified "-" (or perhaps syntax this implies "everything else", I am not sure).

The regular expression for discovering partitions in the command line clearly expects a 0x([0-9a-fA-F]?)@(0x[0-9a-fA-F]?) which does not appear to allow for a "-" before the @. I am sure the fix involves more than just to "or" in the "-" to the size part of the regular expression as one either needs to ask the user to specify the partition size or figure it out from the total NAND size.