linuxfoundation / lfevents

For the Linux Foundation Events website events.linuxfoundation.org
MIT License
20 stars 4 forks source link

lfe_get_sponsors doesn't work for for every use case #93

Closed andycochran closed 5 years ago

andycochran commented 5 years ago

Using lfe_get_sponsors() to put the sponsors post content at the bottom of every event post seems like a brittle solution.

The existing Kubecon Cloudnativecon NA site has a sponsors page that is more that just a grid of sponsors logos. With the current method (adding sponsors post content to every event post), you have to have a sponsors page with the exact same content that is on every other page, and the sponsors page cannot have an additional content that is not on all other pages.

Maybe we need a method of defining the sponsor section content that is not done with event post content of a certain name.

With the existing method, we could pull content from a post with a post_name that's much more explicit and would never be needed for an actual page name — e.g. "Global Sponsors Section." We would also need to filter this page from queries so that it doesn't appear in the menu. This would allow us to have a "Sponsors" page with whatever content needed.

cjyabraham commented 5 years ago

Take a look at this slide. I think what we'll need is this:

/sponsors/ top nav element you can't click on but that contains all Sponsors /sponsors/current-sponsors/ a blank page which imports the content of /sponsors/ /sponsors/become-a-sponsor/ info on becoming a sponsor followed by content of /sponsors/

Would that work?

andycochran commented 5 years ago

What if there's only one sponsors page? Or no sponsors page?

cjyabraham commented 5 years ago

I don't see a problem in either case. One sponsors page would just be /sponsors/. No sponsors page wouldn't import anything.

cjyabraham commented 5 years ago

I think we should just go with what Megan said for now:

We should continue to follow the LF core template that includes a main page called “Sponsors” that only displays sponsor logos and a sub-page of that called “Become a Sponsor” that includes prospectus details

We can always change it later. I've put up a demo here.