search

linuxgurugamer / EngineLightRelit

(Unofficial) Fork of EngineLight for Kerbal Space Program (https://github.com/tatjam/KSP-EngineLight)
MIT License
3 stars 4 forks source link

Light from engine "broken" by Kerbalism or from not ignited engine with minThrust > 0 #10

Closed judicator closed 2 years ago

judicator commented 4 years ago

Light from engine is present in some situations, when it shouldn't be where. Confirmed situations are:

  1. Engine has MinThrust set to value more than zero. In this case engine emits light even when it's not started.
  2. Engine was "broken" by Kerbalism (malfunction or critical failure, but without destroying the engine). Broken engine still emits light. It could be true also for other mod, which may "break" engines, but only Kerbalism was tested at the moment. Images illustrating the problem: Broken engine continues to emit light Engine with minThrust >0 emits light, but it is not started

The solution could be to implement engine status check in getThrottle() function: https://github.com/linuxgurugamer/EngineLightRelit/blob/master/EngineLightRelit/EngineLightEffect.cs#L124