search

linuxgurugamer / EvaFuel

A mod for Kerbal Space Program that makes Kerbals no longer be able to have infinite EVA fuel. A continuation of Vendan's mod of the same name.
http://forum.kerbalspaceprogram.com/index.php?/topic/138474-111-105-evafuel-no-more-infinite-eva-fuel/
MIT License
3 stars 5 forks source link

Don't call ApplicationPath during instantiation #10

Closed SlimJimDodger closed 4 years ago

SlimJimDodger commented 4 years ago

This instantiation call to KSPUtil.ApplicationRootPath fills the deblug mode log file with 100's of megs of bad juju.

Let's move it.

linuxgurugamer commented 4 years ago

You may have a point, but I can't accept this PR. It's replacing almost the entire file, looks like you may have reformatted it?

Please redo, or I'll just do it myself. It's a 2 line change, but you have about 500 lines of diffs

Also, were you on 1.7.3 or 1.8.0?

linuxgurugamer commented 4 years ago

Actually, I just did the fix in my local repo, so it will be updated when I get to the 1.8 updates. I still need to know if you had this happen on 1.7.3 or 1.8.0?

SlimJimDodger commented 4 years ago

This is on 1.7.3., but the bug has existed since day one on all version.

The diffs you are seeing are just whitespace from tab replacements. I'm assuming git has an option to ignore whitespace changes.

linuxgurugamer commented 4 years ago

I really don't care what the differences are. It's your responsibility to not change every line. Git does, but github does not, and I review these on Github.

The bug will be fixed in the next release