Dropped all deprecated models

linuxgurugamer / FTLDriveContinued

Other

4 stars 4 forks source link

Dropped all deprecated models #6

Closed arekbulski closed 6 years ago

arekbulski commented 6 years ago

I know we discussed this, but please let me make an appeal: I am a github developer myself (I maintain Construct library) and I learned that hanging clinging to oooold files is ultimately counterproductive.

people who use such old parts probably use outdated mod as well
quality requires succinctness, less code, less files

Further PRs will be independent of this one, so please take your time to reconsider. I am planning to make heavy changes to C# code as well as the configs (TweakScale integration).

linuxgurugamer commented 6 years ago

Umm, before you get deeply involved in coding, please tell me what you are planning on doing.

Regarding the parts, it doest cost anything to keep them around. It's not code, just images and.config files.

I would be more amenable to a PR which moves them into a "depreciated" directory structure. But there are a number of craft files around which use them

arekbulski commented 6 years ago

Sure, I will move them to "deprecated" directory.

linuxgurugamer commented 6 years ago

You will need to look at all the configs to see if they have a MODEL stanza, if so, you may need to adjust them

arekbulski commented 6 years ago

Can I adjust them just refer to filenames without path? Like this one:

    // --- asset parameters ---
    model = ftlContBcnB.mu

arekbulski commented 6 years ago

Further work will be based on the #7 branch so I withdraw this one.