linuxgurugamer / FTLDriveContinued

Other
4 stars 4 forks source link

Moved all deprecated files, Balanced chargetimes #7

Closed arekbulski closed 6 years ago

arekbulski commented 6 years ago

Moved all old parts to "Deprecated" directory (depreciated means something similar but official terminology is deprecated, old habits die hard). Fixed MODEL stanza and tidy up some spaces->tabs and empty lines.

arekbulski commented 6 years ago

I appologise, GitHub put my second commit into this PR by accident. Since I dont know how to undo it, please just accept both.

Second commit: Balances chargetime (8 8.5 10 seconds respectively on the 3 drives)

linuxgurugamer commented 6 years ago

Please explain why you are changing the parameters. Specifically, I believe you are changing the charge time fro 8 to 10 seconds, why?

Regarding the pr, next time make a separate branch for each set of changes

arekbulski commented 6 years ago

Charge time: I just feel this would seem more balanced. S1 and MK2 drives are similar, S2 is heavy. I figure therefore S1 and MK2 should have similar charge time, and S2 take longer. I am not really "changing" the numbers, rather shuffling them, so charge time is somehow proportional to generated force.

I will do better with separating PRs next time. Sorry for glueing those 2 commits. I havent used GitHub for quite a while and mishandled it...

linuxgurugamer commented 6 years ago

Not a problem with the commits, and I'll accept this one. But it sounds like you want to make some major changes, and I won't accept that unless I know what you are intending to do. I've gotten bit in the past by someone who made lots of changes, which, when I looked at them, didn't fit the mod's intentions, or my vision for it. Thanks for understanding, and I do appreciate someone making contributions

arekbulski commented 6 years ago

Yes, I want to make a major overhaul to FTL.

linuxgurugamer commented 6 years ago

No Tweakscale

Ok, I have no doubt about optimization, I only adopted the mod, I didn't write it.

If you can do them as individual PRs, that would make it easier for me to review before I merge.

Thanks for the summary. Go ahead, with what I said above.

Regarding the techtree, use my post as the basis for the changes for stock and CTT.

Thanks, I look forward to seeing your results

arekbulski commented 6 years ago

It would be little work to add TweakScale but I understand why not add it. FTL is OPED as it is, and upscaling the 2500 iN drive would just be outright cheating.

linuxgurugamer commented 6 years ago

The Tweakscale decision is not technical, but philosophical

If you like, I could do the techtree stuff myself