search

linuxgurugamer / KCT

Kerbal Construction Time - An addon for Kerbal Space Program
GNU General Public License v3.0
11 stars 15 forks source link

[bug] KCT allows recover to wrong storage (VAB/SPH) even if above limits #22

Open Dunbaratu opened 5 years ago

Dunbaratu commented 5 years ago

In my career RP-1 game, my Launchpad was upgraded but my Runway was not yet. Thus I could build a rocket in the VAB for launch that had more mass than would have been allowed if I had built in the SPH for launch.

I did so, and launched to the Launchpad. I realized I needed to edit it a bit more so on the launchpad I pulled up KCT's window and clicked the "recover" button there. But I was being a sloppy user, and had accidentally clicked the SPH version of KCT's "Recover" button, not the VAB version of it.

And it let me do it. I don't think it should. I think you should only be allowed to recover it into the storage that goes along with the kind of launch site it's on (if on Launchpad, can only recover to VAB, not SPH.)

It put my rocket, which is illegal to launch on the un-upgraded runway into the SPH's queue. Now it's stuck there because it now has a tonnage limit too low to be allowed to edit it (even if I click the "switch editor" button to go to the VAB from the SPH, KCT still rememebers the limit, which is probably right, but this means the vessel is stuck in limbo forever (or until I get the funds for a runway upgrade).)

linuxgurugamer commented 5 years ago

What about if you launch a rocket (shuttle) and land it on the runway?

Could you ask this question on the forum, let's see a little discussion before I make a decision

Dunbaratu commented 5 years ago

I think it's fine.... IF you're actually allowed to have a vessel that big in that editor building. The key problem isn't allowing you to recover it to the wrong launch site - but allowing it WHEN that launch site cannot actually let you edit this vessel or work with it in any way, so it gets stuck. If there was a check "see if the runway allows a vessel this long or massive before allowing it to be a valid recovery location", that would make sense. Another thing that would make sense would be letting you swap which site it's in after it's in storage, so it doesn't get stuck that way forever (or until you pay for an upgrade).

linuxgurugamer commented 5 years ago

The easiest thing would be to allow to access a vessel in the other storage, similar to the way the editor can now load files from the other facility

linuxgurugamer commented 5 years ago

Next release will have the Altimeter recover button intercepted Also will have a method to move stored vessels from one inventory to the other

Dunbaratu commented 5 years ago

Thanks for this, by the way. I will likely be installing it once released.