search

linuxgurugamer / KCT

Kerbal Construction Time - An addon for Kerbal Space Program
GNU General Public License v3.0
11 stars 15 forks source link

Airlaunch for Stock #50

Closed siimav closed 4 years ago

siimav commented 4 years ago

Continuation of #48. To make this feature available for stock players, some configs would need to be defined in \GameData\KerbalConstructionTime\AirlaunchLevels.cfg file. Here are the realistic configs I created for RP-1. Ideally some dummy PartUpgrade nodes would also be added to the tech tree to notify the player about what upgrades are available and what effect they have. Config for RP-1 can be seen here. There's also cost and time associated with airlaunch similar to how the rollout works. For this there are 2 new formulas here. At this point I set the default values to 25% of BP and 25% of vessel's Effective cost but didn't make the formulas editable through the settings UI. For RP-1 these values will be configured through the custom preset file anyway but stock might actually need those to be editable.

As for what actual values to use for stock - I personally have no idea. It's been too long since I played a stock career so I don't have the slightest hint of what parameters would fit some average stock vessel.

linuxgurugamer commented 4 years ago

Just looked at your configs, they actually look reasonable. I'll add them and try them out. I'll put a NEEDS[!RP-0] into them so that any changes made will not be active in RP0

linuxgurugamer commented 4 years ago

Oh, regarding the edits, for now I don't think I'll put that in, will depend on how much work is involved.

siimav commented 4 years ago

NEEDS[!RP-0]

No, don't put that there. The RP-1 MM patch removes all configs that might already exist.

linuxgurugamer commented 4 years ago

Ok. What I'll do then is to get it set up and push to github, but not release until you've had a chance to test and make sure it's not causing any problem

siimav commented 4 years ago

Sounds good to me

linuxgurugamer commented 4 years ago

What does:

// All sizes have additional 3, 2, 1 m added on top of the desired value to mitigate B9 reporting bigger sizes than actual

mean? Which value, etc?

linuxgurugamer commented 4 years ago

I've pushed the new configs to Github, but haven't released them to anybody yet. From the little testing I did, seems to work nicely

siimav commented 4 years ago

The issue is with B9 Procedural wings that can make the reported dimensions of the vessel bigger than it actually is. I think only swept wings somehow cause this issue. RO/RP-1 players use only B9 wings for designing aerodynamic surfaces so I added a rough workaround to the bug. The added values are 3m to width; 2m to height; 1m to length.

siimav commented 4 years ago

https://github.com/linuxgurugamer/KCT/commit/a92e6f901921a4263d3293806ff99feb10544914#diff-17bb201fe04466543ab4fe07f3eec96fR6 Btw, those tech names are specific to RP-1 and you would need to find some tech nodes from the stock tree to replace with.

linuxgurugamer commented 4 years ago

Oh, ok. Thanks for reviewing, I'll get that udated this evening

linuxgurugamer commented 4 years ago

Completed in version 1.4.7.11