linuxgurugamer / KCT

Kerbal Construction Time - An addon for Kerbal Space Program
GNU General Public License v3.0
11 stars 15 forks source link

Kerbalism compatibility: reload experiment samples and perform part maintenance #58

Open Defaultldentity opened 4 years ago

Defaultldentity commented 4 years ago

Please add the following to KCT_ModuleTemplates.cfg generation

MODULE
{
    name = Experiment
    firstStart = True
}
MODULE
{
    name = Reliability
    broken = False
    critical = False
    last = 0
    next = 0
    last_inspection = 0
    needMaintenance = False
    enforce_breakdown = False
    running = False
    operation_duration = 0
    fail_duration = 0
    ignitions = 0
}
linuxgurugamer commented 4 years ago

@siimav please review this

siimav commented 4 years ago

I'm not that familiar with Kerbalism PartModules but on first sight it looks good to me. The config above would need to be added to this method: https://github.com/linuxgurugamer/KCT/blob/master/Kerbal_Construction_Time/KCT_BuildListVessel.cs#L418

Defaultldentity commented 4 years ago

I've checked this with Kerbalism authors, they say it looks fine.

It would probably be better if they could provide a config in their own repo for themselves to maintain.