Auto Hire new Kerbals ignores restrictions and breaks Bureaucracy a little

severedsolo commented 4 years ago

As discussed here - using the "Auto Hire" options in the launch GUI:

Bypasses Number of Kerbals available in the Astronaut Complex
Doesn't actually check the player can afford to hire.
Causes an incompatibility in Bureaucracy because it isn't checking for the ProtoCrewMember.inactive flag (unlike the main crew selector).

My recommendation would be to not offer to hire new Kerbals at all if Bureaucracy is installed - simply checking the inactive flag after a new kerbal is hired will just make the player think that it hasn't worked and keep hiring new Kerbals.

linuxgurugamer commented 4 years ago

@siimav Do you want to look at this? Should be pretty simple, but...

siimav commented 4 years ago

I'm unlikely to take a look at it before I get some time to do some RP-1 specific chances to KCT. Not really sure when that time comes though... You could take that task for yourself in case you manage to work on KCT before I do.

linuxgurugamer / KCT

Auto Hire new Kerbals ignores restrictions and breaks Bureaucracy a little #64