search

linuxgurugamer / KCT

Kerbal Construction Time - An addon for Kerbal Space Program
GNU General Public License v3.0
11 stars 15 forks source link

"Building Plans & Construction" list does not scroll in Space Center scene #85

Closed tivec closed 1 year ago

tivec commented 3 years ago

I make use of the building plans window a lot since I launch many very similar rockets. However, in my current playthrough I am having issues where it will not allow me to scroll the list. It seems like the panel grows to accommodate a few more, but the list itself is not scrollable.

image

If I go into the VAB, the list allows me to scroll properly.

KSP_x64_Sird5Kjxch

tivec commented 3 years ago

More findings:

If I scroll with the mousehweel, it sometimes scroll but pop back up immediately. If I queue up enough vessels to have a scroll bar in the build list, the scroll bar on the plans list scrolls correctly with both mouse and dragging the handle, but the construction list also moves.

https://imgur.com/a/kzMYvOs

tivec commented 3 years ago

https://github.com/linuxgurugamer/KCT/blob/bbffdd6ad987f1018a154fd0a5183f6d291016a7/Kerbal_Construction_Time/KCT_GUI.cs#L27

It appears there is no unique scrollpos vector for the build list scrollbar, and since both windows are visible at the same time, there will be a conflict here I believe. This issue should be solved if a new vector was introduced, say scrollposBuildPlan, and this line changed to use it:

https://github.com/linuxgurugamer/KCT/blob/bbffdd6ad987f1018a154fd0a5183f6d291016a7/Kerbal_Construction_Time/KCT_BuildPlans.cs#L193

I unfortunately don't have a development environment to make a pull request for this, but I believe the change should be straight forward.

tivec commented 3 years ago

I set up a build environment (I forgot how frustrating that can be...) and finally managed to compile it on 1.11 with the changes I mention above. This has been filed as pull request 86. It's tested in both a live game and a test save.