linuxgurugamer / KSPAddonVersionChecker

KSP-AVC in-game plugin.
15 stars 14 forks source link

Post-build events #20

Open blowfishpro opened 5 years ago

blowfishpro commented 5 years ago

They seem to depend on use-specific paths which makes it very hard to make changes and verify that they're working

linuxgurugamer commented 5 years ago

The post-build events are specific to my build process and environment. The post-build events merely copy the dll to the local GameData directory and then copies the entire release directory to a test install, the second part is building a release file.

Anyone else should delete the post-build event commands and/or put in their own

blowfishpro commented 5 years ago

My understanding was always that putting user-specific configuration in the repo is generally considered a bad idea. Of course I know not to commit those changes now but it's all to easy for them to accidentally end up in a pull request anyway.

I've found symbolic links are a good alternative to explicitly copying the dll to your KSP install in a post build event. So in this case <ksp_root>/GameData/KSP-AVC would be linked to <git_root>/KSPAddonVersionChecker/GameData/KSP-AVC

But I see other stuff in the post build too and I'm less sure of what it does or if there's a user-independent way to express it

linuxgurugamer commented 4 years ago

I've removed all location-specific parts, and now depend on an environment variable to say where the ksp directory is.