search

linuxgurugamer / KSPAddonVersionChecker

KSP-AVC in-game plugin.
15 stars 14 forks source link

Add workflow to validate this repo's .version files #30

Open DasSkelett opened 4 years ago

DasSkelett commented 4 years ago

This PR adds a workflow to validate KSP-AVC.version and the .version files in GameData/ against the new schema. It uses my GitHub Action found here: https://github.com/DasSkelett/AVC-VersionFileValidator This is what a run would look like for this repository: https://github.com/DasSkelett/KSPAddonVersionChecker/commit/5870090754d8745dcf49d78b39dee0b579f66445/checks?check_suite_id=365374336

It triggers for pushes to a branch of this repository and pushes to foreign branches that have an active pull request to this repo, at least if I've read the documentation right.

All the files in TestCases/ are excluded from validation, because I guess they are purposefully wrong for unit testing purposes? If not and they should be valid... there's a lot of work to do ;)

It can be used as something like a reference implementation I guess.

Let me know what you think!

DasSkelett commented 4 years ago

Since the workflow didn't trigger after creating this PR, I guess workflows are deactivated in the repository settings.

linuxgurugamer commented 4 years ago

I'm a bit concerned over the "GameData". Are you referring to the GameData in this repo?

DasSkelett commented 4 years ago

Yes sorry, that wasn't really clear. This is a CI check that looks at all the version files it can find in the repository by default when it is triggered. After completion it will set a status to the PR if all the validations succeeded (just like Jenkins or Travis or other tools can do). I have excluded the TestCases/ folder of this repository, so currently the only other version files in this repo are the KSP-AVC.version, GameData/KSP-AVC/KSP-AVC.version and GameData/MiniAVC/KSP-AVC.version. I can exclude the two in GameData/ too, but since it represents what finally gets zipped for the download from what I understand, I think it makes sense to include them in the checks.

Edit: To see what it looks like, you can activate workflows in the repository settings, and it may or may not run for this PR.