linuxgurugamer / KSPAddonVersionChecker

KSP-AVC in-game plugin.
15 stars 14 forks source link

MiniAVC ZIP folder structure looks like it's not what was intended #36

Closed HebaruSan closed 3 years ago

HebaruSan commented 3 years ago

Hi @linuxgurugamer,

This is what's in the MiniAVC ZIP file right now:

https://github.com/linuxgurugamer/KSPAddonVersionChecker/releases/download/1.4.1.5/MiniAVC-V2-1.8.0-2.0.0MiniAVC.zip

└── [4.0K May 21 10:55]  GameData/
    └── [4.0K Jun 28  2020]  MiniAVC-V2/
        ├── [ 422 Jun 28  2020]  MiniAVC-V2.version
        ├── [ 14K Jun 28  2020]  MiniAVC-V2.dll.mdb
        ├── [ 44K Jun 28  2020]  MiniAVC-V2.dll
        └── [4.0K Jun 28  2020]  Plugins/
            └── [   0 Jun 28  2020]  placeholder.txt

It looks like the intention here was to put the plugin in the Plugins folder, but it's in GameData/MiniAVC-V2 (the parent folder of Plugins) instead, and the Plugins folder only contains placeholder.txt. I'm guessing there was a mix-up in the build script that generates this file.

Noticed while checking up on this repo for KSP-CKAN/CKAN#2490.

Suggestions

linuxgurugamer commented 3 years ago

I've updated the MiniAVC-V2 zip file to fix the location of the dll

HebaruSan commented 3 years ago

Cool, looks fixed now. The placeholder.txt is still there and probably not needed in the release ZIP, but the Plugins folder contains the plugin now.

image

linuxgurugamer commented 3 years ago

If I do any more releases (most likely not), I'll remove that file, but not worth a release for that