linuxgurugamer / KerbalObjectInspector

See every game object in KSP as the game plays!
GNU General Public License v3.0
2 stars 4 forks source link

Tons of features added, some fixes, a few things removed #6

Closed gotmachine closed 2 years ago

gotmachine commented 3 years ago

image

linuxgurugamer commented 3 years ago

You are saying that the toolbarController was not working properly? I don't understand, it is irrelevent as to what it uses. What wasn't working? I guess you didn't bother to read your emails, I closed this PR. I'll reopen it, but would like to understand what you've done, you made a lot of changes which I have to review

Edit: I just tested the current version, and the toolbar button works well with both the stock and the blizzy toolbar. So now I am extremely puzzled and concerned about the rest of the changes. Please respond

gotmachine commented 3 years ago

EDITED : after more testing, the toolbar issue is indeed a ToolbarController bug. Steps to reproduce :

The fix I did doesn't actually fix anything. I just changed ApplicationLauncher.AppScenes.ALWAYS to declaring each scene individually, but I was mislead by the fact that it is fixed just by relaunching the game.

My guess is that a just-installed ToolbarController is (re)initialized too late, on the first space center scene load, after the KOI KSPAddon was started in the main menu. There aren't many mods using a main menu toolbar button, so the issue has probably gone under the radar.

As for the other changes, what are your concerns ?

Yes I basically rewrote the entire hierarchy class, it was horribly laggy and inefficient, plus it had annoying limitations/issues like the inability to show/find disabled gameobjects and the fact that the hierarchy was in reversed order. And I also did major changes to the inspector to give it all the new abilities I mentioned.

linuxgurugamer commented 3 years ago

My concern was the comment about the button without an explanation. Without doing extensive work, I think your guess is probably right on the money. The only change I suggest would be to instead of adding all the scenes, you can use ALLGAMESCENES. I'll try to review the rest over the next few days

linuxgurugamer commented 2 years ago

Just an FYI, your comment above: My guess is that a just-installed ToolbarController is (re)initialized too late, on the first space center scene load, after the KOI KSPAddon was started in the main menu. There aren't many mods using a main menu toolbar button, so the issue has probably gone under the radar. I am only aware of maybe two or three mods which use buttons on the main menu. TBC does not initialize until the main menu, and in fact, the instructions for using are that the RegisterToolbar method should be called at the mian menu due to initialization sequencing. I don't know why you would want this to be started on the main menu, though