search

linuxgurugamer / KerbinSpaceStation

A contract pack for KSP, designed to replace the current Space Station Missions
Other
4 stars 8 forks source link

"Crew a Base or Station" missions automatically validate upon switching to vessel #4

Closed MaximeBrean closed 5 years ago

MaximeBrean commented 5 years ago

As reported on the forum:

"Crew a Base or Station" is offered for unmanned station or base that have at least 4 available slots (trigger is fine). The mission is validated upon switching to the related station (not tested with base). Crewing the station is then not needed.

Issue encountered with KSP 1.7.3 with a fair amount of mods.

Contract Configurator 1.27.1 has been rebuild using KSP 1.7.3 binaries, source (from tag 1.27.1) patched with MR 678, but it don't do anything with crew calculation. I don't expect an issue there but I will double check with standard CC in an hour or so (I can't do this ATM).

Log (With CC verbose configuration) attached: KSP.zip Log contain only KSP start, mission building access (mission was already accepted), switch to station in LKO and clean game shutdown.

MaximeBrean commented 5 years ago

Issue is also valid on a pristine setup with only MM, CC (official, not rebuilded) and this modpack.

I also noticed that bonus that should be granted by putting the station in orbit with a LAB is not rewarded (but that's another issue)

MaximeBrean commented 5 years ago

Another issue related to the same contract, the mission cooldown is check against another contract type. https://github.com/linuxgurugamer/KerbinSpaceStation/blob/3907b4a6dfad0076ae6f48ae37775268893e9177/GameData/ContractPacks/KerbinSpaceStation/BaseMissions/BasePopulation.cfg#L81 Should be contractType = BasePopulation instead of contractType = CrewRotation I think.