linuxgurugamer / KerbinSpaceStation

A contract pack for KSP, designed to replace the current Space Station Missions
Other
4 stars 8 forks source link

KopernicusSolarPanel #7

Closed Sigma88 closed 3 years ago

Sigma88 commented 4 years ago

the module "KopernicusSolarPanel" is going to be overhauled completely in the next release and it will no longer replace the stock SolarPanel modules

The module itself will also be renamed to "KopernicusSolarPanels" which will trigger some NRE for mods that refer to "KopernicusSolarPanel"

I am torn between keeping an empty "KopernicusSolarPanel" module to avoid breaking mods that might refer to it, but at the same time if the issues don't show up people will not know that they need to change their mods.

I noticed that this mod refers to "KopernicusSolarPanel" so if you need help with switching to the new ones just let me know

linuxgurugamer commented 4 years ago

As a suggestion, to avoid issues, I'd leave it in, but have it display a message at game startup if it is referenced anywhere.

I'll have to see what the new module does, not sure if this would require just a simple change or a big change.

Sigma88 commented 4 years ago

Ideally you should be able to just remove any reference to KopernicusSolarPanel since they now work by modifying the behaviour of stock solar panels rather than by replacing the solarpanels themselves

linuxgurugamer commented 4 years ago

@Sigma88 Could you take a look at the file StationCore.cfg, around line 324, I'm not sure that section is needed anymore based on your previous comments here:

Code in question:

            PARAMETER:NEEDS[Kopernicus]
            {
                name = PartValidationRTG
                type = PartValidation
                hideChildren = true
                title = 1 or more solar panels
                partModule = KopernicusSolarPanels
                minCount = 1
            }
Sigma88 commented 4 years ago

I haven't tracked solar panels lately, they used to have a bunch of issues still when I was working on them and then real life caught up with me and I haven't really had time for ksp since