linuxgurugamer / REKT

Recoverable Emergency Kerbal Transport
Other
0 stars 3 forks source link

Buoyancy #3

Closed AmpCat closed 5 years ago

AmpCat commented 5 years ago

Updated buoyancy values so all the pods float. Also fixed a few localization tags and added some search tags (REKT and OTAV where appropriate) Also spelled buoyancy correctly in github.

linuxgurugamer commented 5 years ago

I can't accept this as it is, yet. You have a lot of files ending in .cfgbak, while I assume that those are backup files, I'd rather let you clean it up. To do so, once you've done the cleanup on your local repo, just commit it and push it into the same branch, the PR will automatically be updated.

AmpCat commented 5 years ago

I thought I deleted all those. I'll take a look and see what happened.

On Fri, Sep 6, 2019 at 07:28 linuxgurugamer notifications@github.com wrote:

I can't accept this as it is, yet. You have a lot of files ending in .cfgbak, while I assume that those are backup files, I'd rather let you clean it up. To do so, once you've done the cleanup on your local repo, just commit it and push it into the same branch, the PR will automatically be updated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/linuxgurugamer/REKT/pull/3?email_source=notifications&email_token=AFRLZ6US7CMR4M3OG7OFZA3QIJEIFA5CNFSM4IUE2KPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6CWEGI#issuecomment-528835097, or mute the thread https://github.com/notifications/unsubscribe-auth/AFRLZ6QSV4NWRCL46QRHY3TQIJEIFANCNFSM4IUE2KPA .

linuxgurugamer commented 5 years ago

No problem, just ping me when it's been udpated

AmpCat commented 5 years ago

Okay, this is strange. My local repository doesn't contain any of those cfgbak files. How're they getting up there? And more importantly, how do I tell git to remove files I don't have on my local repository?

On Fri, Sep 6, 2019 at 10:36 AM linuxgurugamer notifications@github.com wrote:

No problem, just ping me when it's been udpated

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/linuxgurugamer/REKT/pull/3?email_source=notifications&email_token=AFRLZ6UIEPYCPIRNH44SV4DQIJ2HZA5CNFSM4IUE2KPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6DG5RQ#issuecomment-528903878, or mute the thread https://github.com/notifications/unsubscribe-auth/AFRLZ6TL6Y7E2A7EXDBSF3LQIJ2HZANCNFSM4IUE2KPA .

AmpCat commented 5 years ago

Hm, okay, I think I see an issue. I have an old (misspelled) branch which does have those files, but my current one does not. I'll redo the pull request with the current version. (I hope)

AmpCat commented 5 years ago

Did you see the new pull request? I think I got everything sorted out.

On Fri, Sep 6, 2019 at 14:01 Robert York robertlyork@gmail.com wrote:

Okay, this is strange. My local repository doesn't contain any of those cfgbak files. How're they getting up there? And more importantly, how do I tell git to remove files I don't have on my local repository?

On Fri, Sep 6, 2019 at 10:36 AM linuxgurugamer notifications@github.com wrote:

No problem, just ping me when it's been udpated

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/linuxgurugamer/REKT/pull/3?email_source=notifications&email_token=AFRLZ6UIEPYCPIRNH44SV4DQIJ2HZA5CNFSM4IUE2KPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6DG5RQ#issuecomment-528903878, or mute the thread https://github.com/notifications/unsubscribe-auth/AFRLZ6TL6Y7E2A7EXDBSF3LQIJ2HZANCNFSM4IUE2KPA .

linuxgurugamer commented 5 years ago

Yes, been busy, hope to get to this later this evening