search

linuxgurugamer / SXTContinued

Lack's Stock eXTension
Other
17 stars 26 forks source link

Patches are applied to Stock Mun Lander instead of SXT Mun Lander #70

Closed ncanceill closed 5 years ago

ncanceill commented 5 years ago

Description Some patches are applied to the stock MEMLander instead of the MEMLanderSXT.

Root cause When the Munar Excursion Module was renamed from MEMLander to MEMLanderSXT in 5ffd4177f07a1e8ab723c53f2e60b83893547d10 to avoid conflicting with the stock Munar Excursion Module, the corresponding patches were not updated accordingly. Specifically SXT/Patches/ModCompatibility/SXT_TweakScale.cfg and SXT/Patches/ModCompatibility/CLS/CLS_StationsBases.cfg have the problem.

Impact I do not run Connected Living Space, but I run TweakScale and this leads to the infamous double-tweakscale-module issue (which does not break Tweakscale anymore, but still produces an ugly warning when loading a craft in VAB/SPH) and an incorrect default scale for the stock MEMLander.

Fix Obvious: replace MEMLander with MEMLanderSXT in the two files mentioned herebefore.

Additional information The RealPlume config from KSP-RO/RealPlume-StockConfigs also uses the old name MEMLander. Specifically RealPlume-Stock/SXT Continued/MEMLander.cfg has the problem. I will open an issue over there referencing this one. Edit: done, see #83 in RealPlume StockConfigs.

PS: Hi @linuxgurugamer! I run 25 mods managed by you, thanks for all the work 👍

linuxgurugamer commented 5 years ago

Fixed in upcoming release