linuxgurugamer / SXTContinued

Lack's Stock eXTension
Other
17 stars 26 forks source link

SXTmk3Cockpit52 Internal has ugly artifacts on the windows #72

Open ncanceill opened 5 years ago

ncanceill commented 5 years ago

Description There are ugly vertical bars visible in the middle of the two front windows in the SXTmk3Cockpit52 (Mk3 "Marble-8") in IVA

Root cause This cockpit uses the Internal module from the Kossak cockpit, but this does not match the window layout of the Marble-8: the Kossak internal has two front windows but the Marble-8 has three As a result, the window frames from the Marble-8 appear as ugly vertical bars in the middle of the Kossak internal windows (you can tell because the bars light up when the cockpit lights are switched on)

Fix I hacked the issue by moving the Internal module forward, so it clips through the window frames enough so that they are not visible: I set the Z offset to -3 instead of -2.55

@PART[SXTmk3Cockpit52]:FINAL
{
    @INTERNAL[kossakint]
    {
        @offset = 0 , 0.6 , -3
    }
}

The only remaining artifact is a glimpse of the (external) lateral window frames at the lower corner of the (internal) lateral windows; this artifact could be eliminated by moving the Internal module furter forward, but then it would not really correspond to the external model anymore, so I believe -3 is a good compromise

Let me know if screenshots or more details are needed

linuxgurugamer commented 4 years ago

Sounds good, will get it out in the next day or so