linuxgurugamer / ksp-advanced-flybywire

Controller mod for Kerbal Space Program
MIT License
26 stars 11 forks source link

AFBW Hotkey (Shift+L) Not Respecting kOS Input Exclusivity #43

Open FirroSeranel opened 10 months ago

FirroSeranel commented 10 months ago

I'm playing with kOS for the first time, and when in its console in a flight scene, most mod and game hotkeys/binds respect its priority, i.e. I can type code and it doesn't have any effect on the game unless I click outside its window (I'm using Focus Follows Click on clickthrough-blocker if that's relevant). This mod, however, opens anyway with Shift+L, which makes typing capital L slightly, er... irksome.

The relevant code is on lines 503-506, but I'm not sure exactly what the best option is, in order to write a PR. How hard would it be to allow rebinding its hotkey in-game, i.e. make the key combo it listens for a variable? (It did give me a bit of a chuckle that a mod designed to allow total freedom for control binding, itself has a hard-coded keybind, heheh)

Alternatively, maybe a toggleable option for having a keybind at all, or a version that simply removes it and uses the icon in the toolbar? Or perhaps simply exposing it in a config file for those (probably rare) people who don't want the keybind?