search

linuxgurugamer / ksp_toolbar

Common API for GUI toolbars in KSP
BSD 2-Clause "Simplified" License
13 stars 14 forks source link

pull again #2

Closed RonnyWu closed 6 years ago

RonnyWu commented 6 years ago

Forgive me for not having VS. Use sublime to modify these. Some grammatical mistakes may require your help.

about KSP.Localization

linuxgurugamer commented 6 years ago

This won't work, besides having syntax errors, you can't have a non-static default, see the message below:

Error CS0120 An object reference is required for the non-static field, method, or property 'ConfirmDialog.locStringOk' Toolbar D:\Users\jbb\github\ksp_toolbar\Toolbar\Internal\GUI\ConfirmDialog.cs 47 Active

And I already fixed it as follows:

internal ConfirmDialog(string title, string text, Action onOk, Action onCancel, string okText = "OK", string cancelText = "Cancel") : base() { if (okText == "OK") okText = Localizer.Format("#TOOLBAR_UI_OK"); if (cancelText == "Cancel") cancelText = Localizer.Format("#TOOLBAR_UI_CANCEL");

linuxgurugamer commented 6 years ago

Look at the new branch "localization" which has all of your changes and my fixes

RonnyWu commented 6 years ago

thanks !

https://github.com/linuxgurugamer/ksp_toolbar/releases/tag/1.7.16.0 has some problems. image

Can you give me a try?

RonnyWu commented 6 years ago

I need a latest link