search

linuxgurugamer / ksp_toolbar

Common API for GUI toolbars in KSP
BSD 2-Clause "Simplified" License
13 stars 14 forks source link

Inconsistent Licensing Information #30

Closed radj307 closed 1 year ago

radj307 commented 2 years ago

I was digging through the source code for this to learn a bit about modding KSP's UI, and came across a small inconsistency that you may want to clear up.

In Toolbar/Internal/Utils.cs:63:

// The following function was initially copied from @JPLRepo's AmpYear mod, which is covered by the GPL, as is this mod

This mod isn't licensed under the GPL, it's licensed under BSD-2.

Since the differences between the original function and this implementation of the function are relatively minor, that is a violation of the GPLv3 license used by AmpYear. You should rewrite the function from scratch & delete the comment referencing this project as being licensed under the GPL.

anal asf, I know; but I figured you would want to know about it sooner rather than later.

linuxgurugamer commented 2 years ago

Well, thank you so much for creating some extra work for me. It's not as if I don't have anything else to do. I'll have to pull it out and put it into it's own dll, I'm sure everyone who sees this will thank you for slowing KSP down just a little bit more.

If you feel so strongly about this, maybe you could, instead of pointing out a relatively harmless issue, maybe fix it yourself by rewriting the function in question?

I won't be able to get to this for a while, so if you do, I would appreciate the PR

radj307 commented 2 years ago

I don't feel strongly about it, but I'm working on a PR right now anyway; I would like to remind you that I didn't 'create' any extra work here, I just pointed out an inconsistency that I saw.

Edit: It's submitted