linuxha / node-red-contrib-mytimeout

A dynamic count down timer for node-red
MIT License
10 stars 10 forks source link

Feature Request: Allow the "Timer On Payload" to work like the "Warning state payload" #22

Open obbers opened 4 years ago

obbers commented 4 years ago

In some cases, specifically connecting to non-MQTT nodes, the ability to not send the payload further down stream until the off event is triggered, would be very helpful. Right now, I'm filtering it with a switch node first.

linuxha commented 4 years ago

If I understand this correctly, basically if Timer On payload is empty then don't send an on. Hmm, need to look at how to implement that. I do have a trigger that anything not off, cancel or stop (pause will be added eventually) that it triggers the timer to run (but also sends the Timer On payload).

This may take me a few days to analyze.

linuxha commented 4 years ago

Sorry I actually had this done last week but couldn't really do more than basic testing.

https://github.com/linuxha/node-red-contrib-mytimeout/pull/new/feature/no_on_payload

I now need to figure out a way to run this test and all the other tests.

linuxha commented 4 years ago

I've created a new way of testing these flows and discovered that the feature branch doesn't work as expected. This feature is going to take a bit more work.