search

linuxha / node-red-contrib-mytimeout

A dynamic count down timer for node-red
MIT License
10 stars 10 forks source link

Inject json to override default values. Odd behavior. #6

Open pauly7300 opened 5 years ago

pauly7300 commented 5 years ago

Hi. I'm not sure if I'm doing something wrong but I can't seem to pass the msg directly out of the function node from your example, into the mytimeout timer and have it read the override values correctly. It keeps using the default values.

However if I pass the output of the function through a JSON node and then into mytimeout node, it works.

I couldn't figure this out for a while as your example looks like its passing the function output directly to the mytimeout node.

Is this expected?

Thank you!

This is not working: https://hastebin.com/nibefacore.json I pass directly out of function to mytimeout

This is working: https://hastebin.com/geciwoduka.json I pass through json node and then to mytimeout

ps: There is a small typo on the info page inside NR.

screen shot 2018-08-20 at 11 11 58 am

linuxha commented 5 years ago

Hmm, odd, thought my email response would end up here.

Thanks for find the document error and the coding error on not handling the full object from JSON properly. I'm working on that right now.

linuxha commented 5 years ago

Pauly, I've corrected the spelling error and I've updated the msg handling . I've also added an option to ignore case on the input match. This is not in the documentation yet but neither is the debug per timer I added a while ago.

I've noticed another minor issue with an error message that pops up on deploy of the new timers.

"The workspace contains some nodes that are not properly configured: ... are you sure you want to deploy."

You can deploy it's harmless and I have a manual fix but I need to figure out how to word it.

This has to do with my change from a text box to a checkbox.