Searching for running processes with "ps x | grep" is wrong

[danfe]

Results would contain the grep(1) line itself (with arguments), so this construct will always find what's being searched. Also, there's needless use of pipe. Consider the following patch:

-        my $WMs = runCmd("ps x | grep wm");
+        my $WMs = runCmd("pgrep -l wm");
         if($WMs=~/\s(\w+wm)/) {
             $Sys{"Current_wm"} = $1;
         }

-        if(runCmd("ps x | grep start-hello"))
+        if(runCmd("pgrep -l start-hello"))

Now the probe correctly detects my IceWM instead of bogusly reporting that I run helloSystem DE.

[linuxhw]

pgrep -l start-hello returns empty output on helloSystem.

[linuxhw]

Fixed by commit 1274919ef786285bbdcf14329413d7545e68e433

[danfe]

That's because it's not part of the process name (/bin/sh) but its arguments. For that you'd need to use -f switch. From man pgrep(1):

-f Match against full argument lists. The default is to match against process names.

Committed fix is ugly, and now requires two pipes while it can use none.