search

linuxkidd / coachproxy-os

Open Source version of CoachProxy software
GNU General Public License v3.0
36 stars 19 forks source link

Front heat pump #21

Open ODSMarcus opened 3 years ago

ODSMarcus commented 3 years ago

Some units (primarily Vanleigh RVs) may not have a front Heat Pump or it may be moved to a new location in the coach. This allows for this functionality

Resolves #26

ODSMarcus commented 3 years ago

In my specific example, I moved the single HP unit from the front, to the middle, so toggling this works great and the layout follows suit.

image

greendog99 commented 3 years ago

How does one select what layout they have? FYI I don't own a Tiffin (or a CoachProxy) any more so I'm reviewing/approving these based purely on the code -- I don't have a way to see the changes and test them myself.

ODSMarcus commented 3 years ago

This would be adjusted via the normal settings screen via a Toggle, just as the Mid and Rear HP options are set

greendog99 commented 3 years ago

Ah, I see it now in the flows_coachproxy_template.json. If you're up for it, can you also also make those changes in the flows_coachproxy_base.json? That's the initial "first setup" config people see on first boot and usually use to configure the RV.

ODSMarcus commented 3 years ago

I can do that, is it as simple as duplicating to the _base or is there differences between the two? I wasn't 100% sure on that :)

greendog99 commented 3 years ago

It should be really close but I’m not sure if it’s 100% identical. It’s been a really long time since I’ve messed with it! If the surrounding json looks identical, then I guess we can assume the whole thing is identical :-)

On Jul 6, 2021, at 8:55 PM, ODSMarcus @.***> wrote:

 I can do that, is it as simple as duplicating to the _base or is there differences between the two? I wasn't 100% sure on that :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.