[WIP] Update kubernetes

linuxkit / kubernetes

minimal and immutable Kubernetes images built with LinuxKit

Apache License 2.0

400 stars 75 forks source link

[WIP] Update kubernetes #92

Open bjwschaap opened 5 years ago

bjwschaap commented 5 years ago

Also enable external storage provisioners like Ceph RBD. Added eudev needed for detecting device mounts. Without it tools like rbd will timeout waiting for a message on /run/udev/control.

Signed-off-by: Bastiaan Schaap bastiaan.schaap@siteminds.nl

bjwschaap commented 5 years ago

This contains a working eudev package as well (https://github.com/linuxkit/linuxkit/issues/2836)

deitch commented 5 years ago

I won't have a chance to review properly (and test) for a few days yet, but my first thoughts:

thank you. It is good to have this brought up to date, along with all of its dependencies
I noticed you added Calico but didn't enable it?
why did you restrict to -amd64?

deitch commented 5 years ago

Also CI is failing.

bjwschaap commented 5 years ago

@deitch You are right. I'll work through these, as I just built and ran this locally without any concerns for actually pushing it (which I originally hadn't planned). I'll do my best to get the PR up to a better standard. Just did the PR already for now to get feedback/input from you ;-)

deitch commented 5 years ago

Thanks @bjwschaap !

GordonTheTurtle commented 5 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "upgrade" git@github.com:bjwschaap/kubernetes.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354609448
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

bjwschaap commented 5 years ago

@deitch Did you get a chance to look into this PR yet? I'm pretty much stuck at this point, since in order to build the packages, an Alpine 3.10 image from https://github.com/linuxkit/linuxkit/pull/3388 is needed.