search

linuxkit / lcow

Linux containers on Windows built with LinuxKit
Apache License 2.0
225 stars 42 forks source link

Update kernel/opengcs/runc #41

Closed rn closed 5 years ago

rn commented 5 years ago

resolves #38 resolves #37 resolves #39

I have no means of testing this. @jhowardmsft could you review?

lowenna commented 5 years ago

Yes, I can try this out. @rn is there anyway would can put binaries somewhere? I can build initrd from this but I’ve never managed to get a kernel build complete using linuxkit locally.

rn commented 5 years ago

@jhowardmsft try the circleCI artefact: https://81-111085629-gh.circle-artifacts.com/0/release.zip

lowenna commented 5 years ago

Aha! Thanks. Yes will try when I’m the office tomorrow

lowenna commented 5 years ago

@rn LGTM. I've run through some basic validation of networking, commit, pull, run, volume, cp, build and it passed fine.

Iristyle commented 5 years ago

About to try building this on Windows, but hopefully https://github.com/linuxkit/linuxkit/pull/3317 fixes the problem I filed in https://github.com/linuxkit/linuxkit/issues/3207 / removes the need for my linuxkit fork.

UPDATE: Confirmed my linuxkit fork is no longer necessary!

Iristyle commented 5 years ago

Also @jhowardmsft - not sure if https://github.com/linuxkit/linuxkit/issues/3120 is relevant any longer? It still shows up as a note in this repo, but with kernel being bumped to 4.19.27 it would seem it's no longer a concern.

justincormack commented 5 years ago

@Iristyle in #37 he said not

Iristyle commented 5 years ago

In that case I pushed up #44

lowenna commented 5 years ago

@rn @justincormack Could we get a new release cut based on the artifact above?