linuxkit / linuxkit-ci

The CI configuration for testing LinuxKit
Apache License 2.0
6 stars 12 forks source link

Update for new GCP hosting and maintainers #33

Closed talex5 closed 6 years ago

talex5 commented 6 years ago

Also, it seems we need to unset DOCKER_TLS_VERIFY when using a socket now, otherwise the push.sh script fails with:

error during connect:
  Get https://%2Fvar%2Frun%2Fdocker.sock/v1.38/services:
    dial tcp: lookup /var/run/docker.sock: no such host

Signed-off-by: Thomas Leonard thomas.leonard@docker.com

justincormack commented 6 years ago

You really shouldnt have to set tls verify on local socket...

ijc commented 6 years ago

If you are using DOCKER_HOST to flip between local and remote then being able to just set-and-forget DOCKER_TLS_VERIFY (which it appears is what is happening here) would be nice...

Likewise if the script is unaware of the specifics of DOCKER_HOST but definitely knows it wants TLS to be verified if it is being used...

Seems like a regression in the CLI to me.

talex5 commented 6 years ago

@samoht : OK, you're back in!

@ijc: seems to be a known issue, though closed for some reason: https://github.com/moby/moby/issues/36535

justincormack commented 6 years ago

I reopened the issue feel free to add repro

justincormack commented 6 years ago

Since this, CI seems to be totally broken see https://github.com/linuxkit/linuxkit/pull/3170

rn commented 6 years ago

also https://github.com/linuxkit/linuxkit/pull/3173 which has the same error