search

linuxmao-org / VL1-emulator

An emulator of Casio VL-Tone VL1, based on source code by PolyValens
Creative Commons Zero v1.0 Universal
28 stars 2 forks source link

The envelope clicks when stopping a voice to start a new one #14

Open jpcima opened 4 years ago

jpcima commented 4 years ago

Make it a clean transition.

jpcima commented 4 years ago

When ADSR.cpp is edited to not restart at 0 after a re-trigger, ADSR looks better but sound is still clicking.

It's by applying this change:

    //bool bRestart = phase==kAdsrAttack;
    bool bRestart = phase==kAdsrAttack && previousPhase==kAdsrIdle;

Before Capture du 2019-12-24 19-24-27

After Capture du 2019-12-24 19-24-33

To check whether the retrigger is resetting oscillator's phase (which it shouldn't)

jpcima commented 4 years ago

It should be fixed, testing needed