search

linuxmasterrace / Townvalds

A free town plugin for Cuberite
GNU Affero General Public License v3.0
14 stars 4 forks source link

Clean up code for disabling explosions #39

Closed omarroth closed 8 years ago

omarroth commented 8 years ago

From the OnExploding documentation:

If the function returns true, no other callback is called for this event and the explosion will not occur.

This removes the need for several other hooks, and gets rid of the if pyramid for finding the position of entities. Also fixes #26, as it no longer needs to copy blocks.

PureTryOut commented 8 years ago

Why exactly are commits for your pvp pull request in here? Please make any new stuff you do in a seperate branch, and make a pull request of that. If you do anything in master you'll make a mess.

omarroth commented 8 years ago

Cleaned up commit history, should be good to go now.

PureTryOut commented 8 years ago

Thanks, much cleaner. Merging