search

linuxmint / blueberry

A Bluetooth configuration tool
GNU General Public License v3.0
171 stars 51 forks source link

obex: Remove hard requirement on deprecated hcitool #103

Closed cptpcrd closed 4 years ago

cptpcrd commented 4 years ago

Allows fallback on bt-device from bluez-tools.

Context: I run Arch, and I was unable to get file transfers from other devices working in blueberry (which is in Arch's repos). It turns out that Arch's version of bluez-utils is newer and does not include the deprecated hcitool, which is required by the obex agent. This fix made it work.

I know this is somewhat hacky; I'm happy to edit if you have any suggestions.

mtwebster commented 4 years ago

Hi, this works fine but it's probably ok just to remove the use of hcitool entirely - we have bt-device command available everywhere, and I don't think there's any reason we can't (especially for just getting the device name).

cptpcrd commented 4 years ago

Updated. Better?

mtwebster commented 4 years ago

Thanks!