search

linuxmint / blueberry

A Bluetooth configuration tool
GNU General Public License v3.0
171 stars 51 forks source link

Don't use /usr/bin/env to call python3 #111

Closed okaestne closed 3 years ago

okaestne commented 3 years ago

This avoids problems like issue #96

SuperSandro2000 commented 3 years ago

This does not solve the issue for eco systems like nix which do not have /usr/bin/python3. I am for a revert of this and a proper fix.

okaestne commented 3 years ago

Using /usr/bin/env would be against the Debian Python Policy.

Also most other Mint tools use /usr/bin/python3, do they cause issues as well?

leigh123linux commented 3 years ago

@SuperSandro2000 How did nix fix this?

https://github.com/linuxmint/cinnamon/commit/ffbd4a767e225367f8b34a568172c95d7d908ff6

Is patchShebangs a nix script to fix shebangs?

https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/cinnamon/cinnamon-common/default.nix#L132

SuperSandro2000 commented 3 years ago

Using /usr/bin/env would be against the Debian Python Policy.

We a conflict of interest here.

Also most other Mint tools use /usr/bin/python3, do they cause issues as well?

Without patchShebangs, yes.

Is patchShebangs a nix script to fix shebangs?

Yes. We can always fix it but it is some extra step which could be avoided.