Note: Hardware RF switch untested. I expect it works as usual though, it should show a page identical to bluetooth disabled in the screenshot below except with the additional "by hardware switch" text.
UI cleanup:
Reworks UI to have less wasted space by moving everything into a header bar except the bluetooth widget and status page.
Static UI layout done with glade/gtkbuilder.
gnome-bluetooth BluetoothSettingsWidget override fix:
Widget override code now loops through widgets to find them instead of using a hardcoded "path". It's still fragile. Adding version-specific code is probably the best approach if it breaks again.
Better support for hotpluggable devices:
Always looks for an adapter instead of only starting if we have an adapter and stopping once when we lose it.
Supports first device index being above 9, which can happen easily with a single hotpluggable device(USB)
"No adapters" status page now uses dialog-info icon
Better rfkill error state presentation:
Previously, when the user did not have permission to /dev/rfkill, the main status page was used to show an error state with a bluetooth disabled icon and the switch set to off and insensitive. This would likely be reached most often by a user attempting to disable bluetooth. This layout may be misleading because it could suggest that bluetooth is disabled when it's actually still enabled and discoverable, and that the application no longer worked because of rfkill permission issues.
The new layout places an rfkill-error-specific image which shows a dialog-error icon next to the toggle switch when an enable/disable operation fails. The error is explained by the image's tooltip which may have low discoverability. A new message was added that explains having a udev rule or being in the rfkill group can fix permissions issues.
This rfkill-specific error state no longer modifies the powered or present states for bluetooth adapter status, which allows the application to work as expected regardless of rfkill permissions.
Note: Hardware RF switch untested. I expect it works as usual though, it should show a page identical to bluetooth disabled in the screenshot below except with the additional "by hardware switch" text.
UI cleanup:
gnome-bluetooth BluetoothSettingsWidget override fix: Widget override code now loops through widgets to find them instead of using a hardcoded "path". It's still fragile. Adding version-specific code is probably the best approach if it breaks again.
Better support for hotpluggable devices:
Better rfkill error state presentation: Previously, when the user did not have permission to /dev/rfkill, the main status page was used to show an error state with a bluetooth disabled icon and the switch set to off and insensitive. This would likely be reached most often by a user attempting to disable bluetooth. This layout may be misleading because it could suggest that bluetooth is disabled when it's actually still enabled and discoverable, and that the application no longer worked because of rfkill permission issues.
The new layout places an rfkill-error-specific image which shows a dialog-error icon next to the toggle switch when an enable/disable operation fails. The error is explained by the image's tooltip which may have low discoverability. A new message was added that explains having a udev rule or being in the rfkill group can fix permissions issues.
This rfkill-specific error state no longer modifies the powered or present states for bluetooth adapter status, which allows the application to work as expected regardless of rfkill permissions.