search

linuxmint / cinnamon-control-center

A collection of configuration plugins used in cinnamon-settings
GNU General Public License v2.0
62 stars 65 forks source link

Symlinking desktop files fail when certain options disabled #289

Closed vishwin closed 2 years ago

vishwin commented 2 years ago 
 * latest git
 * any, but running FreeBSD
 * Intel modesetting
 * amd64

Issue Especially after ca95ce7dfc4872ecef88b0074d2bee8f097d0394, because the four desktop files are hardcoded in meson.build, symlinking fails when any of the color, networkmanager or wacom options are disabled, because the relevant desktop file was never built or staged.

Steps to reproduce Build and install from source as normal, but disable any of the color, networkmanager or wacom options ie -Dcolor=false

Expected behaviour Only the options enabled in meson have desktop files symlinked.

Other information

eli-schwartz commented 2 years ago

The fallback on install-scripts/desktop-file-links.py would simply run subprocess.call(['ln', '-s', ...]) for every single one, which didn't bother to check if it fails. When I contributed commit ca95ce7dfc4872ecef88b0074d2bee8f097d0394 I transcribed the symlinking file but neglected to check whether it was optional to install them. It should be simple enough to check the options first.