search

linuxmint / cinnamon-control-center

A collection of configuration plugins used in cinnamon-settings
GNU General Public License v2.0
62 stars 67 forks source link

[TODO] Package cleanup needed, remove unused, cleanup buildfiles, etc.. #67

Open darealshinji opened 10 years ago

darealshinji commented 10 years ago

You forgot to add the xpm icon to the *.install file.

--- a/debian/cinnamon-control-center.install
+++ b/debian/cinnamon-control-center.install
@@ -1,3 +1,4 @@
 usr/bin
 usr/lib/cinnamon-control-center-1/panels/*.so
 usr/share/applications
+debian/cinnamon-control-center.xpm /usr/share/pixmaps

Also, Lintian points out several warnings about desktop-command-not-in-package in the package cinnamon-control-center_2.2.8+qiana_amd64.deb. You should consider overriding them, if that command is already installed with one of the dependencies: cinnamon-control-center binary: desktop-command-not-in-package usr/share/applications/cinnamon-*.desktop cinnamon-settings

mtwebster commented 10 years ago

This package needs massive cleanup for this type of stuff. It stems from the fact that this used to be a self-contained program. Now we only use the panel plugins (/usr/lib/cinnamon-control-center-1/panels/lib/*.so), which are imported into cinnamon-settings.

Everything else is dead code basically, or, in the case of cinnamon-control-center binary, used only for debugging. Hopefully this cycle someone or myself gets around to doing this cleanup.

mtwebster commented 10 years ago

I took the liberty of editing this issue's title to make it a bit more urgent.

icarter09 commented 9 years ago

What's the best way to properly figure out what code can be removed or not? Is everything that falls into the "desktop-command-not-in-package" a candidate for removal?

icarter09 commented 4 years ago

@mtwebster what all still needs to be done on this TODO list?