gnome-wall-clock.c: Fix usage of LC_TIME

linuxmint / cinnamon-desktop

The cinnamon-desktop library (and common settings schemas for the cinnamon desktop)

GNU General Public License v2.0

187 stars 63 forks source link

gnome-wall-clock.c: Fix usage of LC_TIME #141

Closed Cobinja closed 4 years ago

Cobinja commented 4 years ago

In gnome_wall_clock_lctime_format(), this uses LC_TIME if set. If LC_TIME is not set, is uses LANGUAGE. That neither is set, it uses the unlocalized format string.

clefebvre commented 4 years ago

The bug is valid, but there's two issues in the PR:

We should always use dgettext.. and never return format_string.. that's the actual bug.
dcgettext can't be used, it fetches the translation from /usr/share/locale/$LANGUAGE/LC_TIME/cinnamon.mo... what we want is the opposite, we want /usr/share/locale/$LC_TIME/LC_MESSAGES/cinnamon.mo.

Superseded by https://github.com/linuxmint/cinnamon-desktop/pull/142