linuxmint / cinnamon-desktop

The cinnamon-desktop library (and common settings schemas for the cinnamon desktop)
GNU General Public License v2.0
187 stars 63 forks source link

gnome-bg.c: don't decrement hour by 1 when parsing xml backgrounds #175

Closed sudorook closed 3 years ago

sudorook commented 3 years ago

I've noticed that the times at which desktop background transitions take place are off by 1 hour compared to what is specified in the XML files. Increasing the value in the hour field by 1 fixed the issue.

I looked into why, and the culprit is that the value stored in the field is decremented by 1. Maybe someone assumed hours were being counted from 0 to 23.

Assuming that the code was forked from GNOME, I looked into gnome-desktop, and the issue is noted there, too. (https://gitlab.gnome.org/GNOME/gnome-backgrounds/-/issues/4), and the same fix as the one in this pull request is waiting to be merged (https://gitlab.gnome.org/GNOME/gnome-desktop/-/merge_requests/97).