search

linuxmint / cinnamon-desktop

The cinnamon-desktop library (and common settings schemas for the cinnamon desktop)
GNU General Public License v2.0
188 stars 62 forks source link

icons with more than one dot in file name are not displayed in task bar #242

Open MartinP1 opened 3 months ago

MartinP1 commented 3 months ago

Affected Version: Cinnamon 6.0.4. (only Version tested)

Linux Mint 21.3 "Virginia" up to date patch level

Method to reproduce:

Effect:

Problem appars in Package "Frescobaldi" (Music sheet editor) of linux mint, that provides an icon named "org.frescobaldi.Frescobaldi.svg"

fredcw commented 3 months ago

The problem here is not the number of dots in the name as many icon names have more than one. I think the problem is the capital "F" which is not allowed according to Freedesktop's Icon Naming Specification:

As a further restriction, all icon names may only contain lowercase letters, numbers, underscore, dash, or period characters.

Best to report bug to app developer I think.

MartinP1 commented 3 months ago

Thanks for your Reaction

https://github.com/frescobaldi/frescobaldi/issues/1769

I am not very hopeful concerning a reaction...

Frescobaldi is unfortunately close to being unmaintained at present. Releases are extremely difficult to do due to deep packaging issues especially on macOS (issues with the macOS label) and Frescobaldi is still using PyQt5, which is now obsolete (https://github.com/frescobaldi/frescobaldi/issues/1407). Help to resolve these issues and continue the development of Frescobaldi is very welcome.

fedelibre commented 3 months ago

Hi all

I'm in charge of Frescobaldi freedesktop stuff.

I'm not sure that the problem is really the capital F. I see what the spec (very old, by the way, latest change in 2006?!?) says, but I also see that all the GNOME applications use the app name capitalized. Does the problem occur with these apps? If not, then the problem might be somewhere else.

fedelibre commented 3 months ago

@MartinP1 The first thing I would check is the presence of other Frescobaldi icons. You may have done manual installations and those icons might interfere...

Please paste the output of this command:

sudo find / -name *rescobaldi.svg
fedelibre commented 3 months ago

In the desktop file spec we see instructions which reflect how names are used in every application:

The name of the desktop entry should follow the "reverse DNS" convention: it should start with a reversed DNS domain name controlled by the author of the application, in lower case. The domain name should be followed by the name of the application, which is conventionally written with words run together and initial capital letters (CamelCase). For example, if the owner of example.org writes "Foo Viewer", they might choose the name org.example.FooViewer, resulting in a file named org.example.FooViewer.desktop.

I don't see why icon names should be written differently from the desktop file.

fedelibre commented 3 months ago

On the other hand, if I look at the AppStream spec I read something differently:

Additionally, even though uppercase letters are permitted in a component-ID, it is strongly encouraged to only use lowercase letters for the ID.

The ID must follow a reverse-DNS scheme, consisting of {tld}.{vendor}.{product}, for example org.kde.gwenview or com.hugski.colorhug2.

It might be a new direction that apps haven't picked up yet.

fredcw commented 3 months ago

@fedelibre You're right, I don't think it's a problem with the icon or the icon name. I think it's something to do with setting an icon for the application or the application's main window in the application itself, rather than the icon in the .desktop file. The problem also occurs in MATE desktop where a generic application icon is used in the taskbar as well. I haven't tested xfce.