linuxmint / cinnamon-settings-daemon

The settings daemon for the Cinnamon desktop
GNU General Public License v2.0
57 stars 58 forks source link

Need to debounce multiple rfkill events. #344

Open khfeng opened 3 years ago

khfeng commented 3 years ago
 * csd version - 4.8.5-1
 * Distribution - Ubuntu Impish Indri
 * Graphics hardware *and* driver used - Intel and i915
 * 32 or 64 bit - 64bit

Issue Newer HP laptops use Intel HID driver to send rfkill hotkey event, so we'll need to unmask Intel HID in hwdb to make airplane mode hotkey work: https://github.com/systemd/systemd/pull/20219 However, this will make both Intel HID driver and HP Wireless driver send rfkill events on older HP laptops, so only the first event like should be processed, like this implementation in G-S-D: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/-/merge_requests/244 The current behavior is that WiFi and Bluetooth get quickly disabled and enabled after pressing airplane mode hotkey.

Steps to reproduce

  1. Apply the change in https://github.com/systemd/systemd/pull/20219
  2. Press airplane mode hotkey.
  3. WiFi and Bluetooth gets disabled then enabled immediately.

Expected behaviour WiFi and Bluetooth should be disabled.

Other information Seems like the entire rfkill part is missing in C-S-D, so I can't do a straight backport from G-S-D.