search

linuxmint / cinnamon-settings-daemon

The settings daemon for the Cinnamon desktop
GNU General Public License v2.0
57 stars 58 forks source link

Fail to build 6.0.0 using GCC 14+ #394

Closed fulalas closed 3 months ago

fulalas commented 3 months ago 
../plugins/keyboard/gkbd-configuration.c:343:35: error: returning ‘gchar **’ {aka ‘char **’} from a function with incompatible return type ‘const char * const*’ [-Wincompatible-pointer-types]
  343 |         return configuration->priv->full_group_names;
      |                ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
../plugins/keyboard/gkbd-configuration.c: In function ‘gkbd_configuration_get_short_group_names’:
../plugins/keyboard/gkbd-configuration.c:349:35: error: returning ‘gchar **’ {aka ‘char **’} from a function with incompatible return type ‘const char * const*’ [-Wincompatible-pointer-types]
  349 |         return configuration->priv->short_group_names;

Adding -Wno-incompatible-pointer-types fixes the issue, but maybe you should take a better look.

Slackware current x64

leigh123linux commented 3 months ago

This is already fixed in master https://github.com/linuxmint/cinnamon-settings-daemon/commit/48da3c4763bea93ea3e1d2ba2e2dfdb7f41d8afc

leigh123linux commented 3 months ago

but maybe you should take a better look.

Slackware current x64

Why don't you try having a better look next time!

fulalas commented 3 months ago

Why don't you try having a better look next time!

Man, please... Don't be an asshole.