linuxmint / cinnamon-spices-applets

Applets for the Cinnamon desktop
http://cinnamon-spices.linuxmint.com
606 stars 509 forks source link

[sound150@claudiux] Icon near the volume slider does not show #5576

Closed sphh closed 7 months ago

sphh commented 7 months ago

Applet version/Build date

Version 6.3.0 (2024-03-08 20:25:01)

Cinnamon version

Cinnamon 6.0.4

Distribution

Linux Mint 21.3 Cinnamon

Graphics hardware and driver used

No response

Applet name and maintainer

sound150@claudiux @claudiux

What happened?

The icon beside the volume slider does not show the loudspeaker (or has the loudspeaker in the same colour as the background): Screenshot from 2024-03-08

The standard sound applet shows the icon.

BTW the icon beside the volume slider also shows the microphone off badge, even if the microphone is not muted. This badge is not necessary here at all, because the microphone volume slider is just below …

Other information

No response

claudiux commented 7 months ago

This is normal. The microphone (crossed-out) only appears as a badge on the output volume icon when the microphone is muted, which is not the case here.

claudiux commented 7 months ago

If you want to see the microphone status all the time, I have to create new icons. So this is not an issue, but a feature request.

sphh commented 7 months ago

Sorry, I do not understand you: It is normal, that the loudspeaker symbol cannot be seen near the volume slider?

sphh commented 7 months ago

If you want to always see the microphone status, I must create new icons. Then, this is not an issue, but a feature request.

No, I do think, that the icon beside the volume slider should not show any microphone status at all.

claudiux commented 7 months ago

image This is normal with mic not muted.

image With mic and output volume muted.

claudiux commented 7 months ago

No, I do think, that the icon beside the volume slider should not show any microphone status at all.

Ok. This is much easier to do.

claudiux commented 7 months ago

Solved. I'll make a PR soon.

sphh commented 7 months ago

This is normal with mic not muted.

With mic and output volume muted.

This is what I expect. But if you had a look at my screenshot, there is only the microphone status badge but no loudspeaker symbol!

sphh commented 7 months ago

Solved. I'll make a PR soon.

Thanks for removing the microphone status badge!

claudiux commented 7 months ago

Done. Please wait for the update.

sphh commented 7 months ago

Updated to Version 6.3.0 (2024-03-08 22:36:01), still the icon with the loudspeaker does not show: Screenshot from 2024-03-08 22-54-29

claudiux commented 7 months ago

What theme are you using? I'm using Mint-Y-Dark.

sphh commented 7 months ago

Application: Mint-Y-Orange Icons: Mint-Y-Sand Desktop: Mint-L-Orange

The default sound applet shows that icon correctly, if that is any help.

claudiux commented 7 months ago

Yes, I can see that. These icons are not well suited to the Mint-L themes. The icon is here, but is only displayed by hovering over it with the mouse.

claudiux commented 7 months ago

In short, I still have a lot of work to do on this.

claudiux commented 7 months ago

Solved! Now the icon still appears. I'm making a new PR. But I'll rework my icons... later.

claudiux commented 7 months ago

@sphh Done. Can you please try the version 6.3.1 of this applet?

sphh commented 7 months ago

I just updated the applet to Version 6.3.1 (2024-03-09 00:41:48). I can confirm that the icon is visible now. Thanks.