linuxmint / cinnamon-spices-themes

Themes for the Cinnamon desktop
http://cinnamon-spices.linuxmint.com
152 stars 129 forks source link

Cinnamox-Rhino #651

Open Padre2 opened 4 years ago

Padre2 commented 4 years ago

 * Themes version/Build: update 260720 (#650) 
 * Cinnamon version:  4.6.6
 * Distribution - Arch 5.7.10
 * Graphics hardware;  ATI/Radeon
 * Snippet or attachment of ~/.cinnamon/glass.log
---
 * Snippet or attachment of ~/.xsession-errors

** (nemo-desktop:754): WARNING **: 10:33:19.201: Current gtk theme is not known to have nemo support (Cinnamox-Rhino) - checking...

---
<!-- Author list: https://github.com/linuxmint/cinnamon-spices-themes/blob/master/.github/CODEOWNERS -->

**Notify author of theme**
@smurphos

**Issue**
nemo-desktop WARNING: Current gtk theme is not known to have nemo support (Cinnamox-Rhino)
Also in .xsession-errors several lines of 
`Cinnamon warning: Log level 128: posix_spawn avoided (automatic reaping requested) (fd close requested)`

**Steps to reproduce**

Load Cinnamon desktop

**Expected behaviour**

No warnings

**Other information**
Has occurred with earlier versions.
How can nemo support be provided?
Is it possible to fix this warning?
smurphos commented 4 years ago

Hi @Padre2 - unfortunately it's not possible to get rid of the warning about Nemo support without patching Nemo. It does have Nemo support, which Nemo does then realise when it checks through the theme, but it's not on a very short hard-coded list of themes that Nemo knows for sure have support - https://github.com/linuxmint/nemo/blob/master/src/nemo-application.c#L242

The Cinnamon warning: Log level 128: posix_spawn avoided (automatic reaping requested) (fd close requested) warnings are not theme related. See https://github.com/linuxmint/cinnamon/issues/9322 - it's just an informational warning.

Padre2 commented 4 years ago

@smurphos Hi, Thank you for your reply with the links. This cinnamox-rhino theme is great for my desktop and despite the warning seems to work well with nemo.

As a relative newcomer to Linux, I try to find the causes of any warnings. I opened the nemo-application.c file and saw the lines that check theme compatibility. You refer to a very short hard-coded list of themes that Nemo knows for sure have support, where is this list located? As an exercise, I am curious as to how, or where you would make a patch to prevent the warning.

Regarding the Cinnamon warning: Log level 128: posix_spawn avoided (automatic reaping requested) (fd close requested), I have noted that these usually appear immediately after the loading of an applet, desklet, or extension, so when these appeared immediately following the loading of the theme, I assumed that it was because of the first non-support warning.

silocoder commented 4 years ago

I have this issue too .xsession-errors making hard to debug other apps. Cinnamon 4.6.6. Would be nice to get patch.

smurphos commented 4 years ago

@Padre2 -the hard-coded list of themes is defined in nemo's source code here https://github.com/linuxmint/nemo/blob/master/src/nemo-application.c#L242 .

If the GTK / Controls theme's name includes the words mint, numix or arc (not case sensitive) nemo assumes it's got support and the message isn't produced. For every other theme name the message is produced and then nemo scans the theme to see if it includes style-classes specific to nemo. If it does all is well. If it doesn't nemo then enforces some mandatory theming and a further message is produced e.g. with the Adwaita theme you'll see this

** (nemo:505523): WARNING **: 19:15:13.246: Current gtk theme is not known to have nemo support (Adwaita) - checking...

** (nemo:505523): WARNING **: 19:15:13.291: The theme appears to have no nemo support.  Adding some...
Padre2 commented 4 years ago

@smurphos Sorry, it took two attempts before I realized that the very short hard-coded list of themes was in the lines 243-245 I have been unable to locate the file nemo-application.c on my computer. Where is is located?