search

linuxmint / cinnamon

A Linux desktop featuring a traditional layout, built from modern technology and introducing brand new innovative features.
GNU General Public License v2.0
4.5k stars 732 forks source link

Menu editor can't/doesn't know how to handle the + character in a file name #10801

Open rado84-github opened 2 years ago

rado84-github commented 2 years ago 
 * Cinnamon version: 5.2.7
   * Distribution: Arch Linux
 * Graphics hardware *and* driver used: GTX 1660 Ti 6GB, 510.54
 * Architecture: 64 bit

Issue Creating a menu item for a program with the '+' character in the file name doesn't work as it should. Create a shortcut to any windows program, for instance mp3tag or irfanview - the shortcut creation works perfectly fine by just selecting the program's exe and there's no need to put 'wine' in front of it. But if you try to create a shortcut in the menu for Notepad++, whose executable is named notepad++.exe, the "OK" button doesn't lit up, thus not allowing you to create the shortcut. The only way for the menu editor to accept the shortcut is to enter 'wine' before the full path to the exe.

While the above workoaround works, it also slows down the program loading by at least 3 times.

Steps to reproduce

  1. Open menu editor and click "create a new item".
  2. Navigate to the notepad++ exe and double click it to select it.
  3. Observe the behavior of the "OK" button after you do the selection - it won't lit up, which means shortcut creation is not possible.

Expected behaviour Shortcuts creation should be possible, even with a "+" character in the file name.

Other information not-lit

lit

mtwebster commented 2 years ago

I can't reproduce this - I can create a launcher with an executable with + in it (I used 'test++.py', marked executable), and it considers that valid.

I'm barely a novice with wine - perhaps it could be a permissions problem? Does it work if you simply try to run it from a terminal? Can you rename one of the other programs that work to have a + and try it?

rado84-github commented 2 years ago

I don't think it's about permissions bc the same thing is happening when the exe is in /home of my user (my user is admin).

simplescreenrecorder-2022-05-21_18.25.48.mkv https://www40.zippyshare.com/v/rlRmL2U5/file.html

Tibladar commented 2 years ago

It's the executable bit. Without it the "OK" button is always disabled.

chmod +x notepad++.exe should do the trick

Tests done: l++.exe -x: not working l.exe -x: not working l -x: not working l++.exe +x: working l.exe +x: working l +x: working