Screenshot is overwritten with new screenshot

Fool4UAnyway commented 9 months ago

Distribution

Linux Mint 21.3 Virginia

Package version

Cinnamon 6.0.4

Graphics hardware in use

Some cheap one

Frequency

Always

Bug description

When I open a new Screenshot (by using Alt+PrintScreen), apparently the screenshot information in other open instances gets overwritten. If I use Copy to Clipboard in the other instance(s), always the last screenshot will be copied. I tried to save the screenshot of an earlier instance, but could not find the file. I guess it is just not there anymore. Now I think of it: probably nothing gets copied as well from the earlier instance. I guess the screenshot has just gone.

Steps to reproduce

Just create a screenshot by pressing Alt+PrintScreen and the Screenshot window appears. Do this again to create another screenshot. Go back to the first instance and use the Copy to Clipboard or Save button. Paste the screenshot in Drawing or look for the file.

Expected behavior

I think each instance should keep its own screenshot safely and allow to copy it to the clipboard or save it as a file independently from what happens later. Imagine you create a new document in your word processor and all open documents are gone...

Additional information

If this is not the desired or expected behavior, the alternative would be to just show the screenshot has gone in the earlier instances. That would at least be correct feedback about the current state.

geropl commented 2 months ago

If I use Copy to Clipboard in the other instance(s), always the last screenshot will be copied. I tried to save the screenshot of an earlier instance, but could not find the file.

Seeing exactly the same: When taking multiple partial screenshots - which opens multiple windows in parallel - , on "Copy" always copies the latest to the clipboard. In addition, when clicking any "Cancel", all screens are closed at once. IIRC this bug got introduced a bunch of month ago (8-12 maybe?)

I'd be interested to fix this, as I have to work around it on a daily basis. I tried to take a look at the source, and there were some changes 8-9 months ago. But I'm lagging context on Linux Mint desktop programming, so would need a few pointers on what to look for. :slightly_smiling_face: @mtwebster Could you help me maybe get started here? (pinging you because saw that you made some changes to screenshot.c and screenshot.js)

jkirk commented 1 month ago

I am running Debian/bookworm with Cinnamon 5.6.8 and just noticed the same problem.

I usually use a custom script / keybinding to take area-screenshots where the problem does not appear. But when I try to take "windows-screenshot" or full screen "screenshot" the last screenshot gets overwritten.

My current media keybindings:

❯ dconf dump /org/cinnamon/desktop/keybindings/media-keys/
[/]
area-screenshot=@as []
screensaver=['<Primary><Shift><Alt>l', 'XF86ScreenSaver']
screenshot=['Print']
screenshot-clip=['<Primary>Print']
window-screenshot=['<Alt>Print']
www=['XF86WWW', '<Shift><Super>f']

jkirk commented 1 month ago

Since a few weeks a gnome-screenshot process was stuck:

  ❯ ps -ax | grep screen
     4507 ?        Sl     0:37 csd-screensaver-proxy
  3212494 ?        S      0:00 /bin/bash /home/jkirk/bin/screen-upload.sh -o
  3212504 ?        Sl     0:20 gnome-screenshot -a -f /home/jkirk/Pictures/screenshots/screenshot_20240924T172158.png
  4039244 pts/41   S+     0:00 grep --color=auto screen

  ❯ killall gnome-screenshot

After killing it, the screenshots were not overwritten anymore. Hope this helps somebody!

linuxmint / cinnamon