search

linuxmint / cinnamon

A Linux desktop featuring a traditional layout, built from modern technology and introducing brand new innovative features.
GNU General Public License v2.0
4.4k stars 722 forks source link

cinnamon theme: fix expo-workspaces-name-entry #12171

Closed fredcw closed 3 days ago

fredcw commented 3 weeks ago

remove fixed width and adjust height.

before:

Screenshot from 2024-04-27 04-38-35

After:

Screenshot from 2024-04-27 04-41-07

anaximeno commented 3 weeks ago

I believe the Cinnamon and the Linux Mint themes might need to update the tooltip style as well, I'm thinking of something similar to their notification style, what do you think about that?

fredcw commented 3 weeks ago

@anaximeno IMO I think the tooltip should look sufficiently different from a popup menu so that they're not easily confused. However the yellow tooltip doesn't really seem in keeping with the rest of the theme, it stands out as a bit odd. Most themes seem to use the inverse colors of a popup menu for the tooltip. So not sure about this one, I haven't really given it much thought, so I guess I don't really know. 🤷‍♂️

JosephMcc commented 3 weeks ago

I think the current yellow is actually appropriate. It's easy to read and stands out the way a tooltip should. The way it's done in some of the other themes isn't ideal now. Some of those are very hard to read the text against the overly bright backgrounds.

anaximeno commented 3 weeks ago

I would say that the main issue with tooltip theming is to have great overall contrast between the text and the tooltip background and the most common/recurrent colors (and brightness) that the user may face below the place the tooltip is being (or will be) shown, despite that I still do believe the current tooltip look on mint-y themes makes sense since it gives a more "cohesive" general look of the system (and some would say it is more modern), so probably the best solution would be something that is in the intersection of all these points.

I don't use the Cinnamon and the Linux Mint themes very frequently, so I wanted to hear more opinions to see if that change was relevant/necessary, so thank you for your input on this!

fredcw commented 1 week ago

@A1exKH

Do you have any ideas about failed verification?

They can be ignored. It just false negatives from the spellchecker.

mtwebster commented 3 days ago

Can you put a min-width there at least? Otherwise, it shrinks to nothing as you backspace, which is unexpected.

I tried min-width: 100px and got:

image

I know we're trying to get rid of excessive width, but there still needs to be some.

Thanks!

edit: smaller image

fredcw commented 3 days ago

@mtwebster Good idea. How about 80px min as that's just about the width of the default name "Workspace 1" with default font?

mtwebster commented 3 days ago

Looks good to me